[docker-pmon] stop passing xcvrd dom_* flags#28306
Draft
aditya-nexthop wants to merge 1 commit into
Draft
Conversation
xcvrd now resolves dom_temperature_poll_interval and dom_update_interval from the "xcvrd" section of pmon_daemon_control.json via XcvrdConfig instead of --dom_temperature_poll_interval/--dom_update_interval CLI flags, so these template blocks are no longer needed. Signed-off-by: aditya-nexthop <aditya@nexthop.ai>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
HLD Link
Previously, each new xcvrd tunable required threading a new
--flagthrough argparse, the supervisord Jinja2 template, and theDaemonXcvrdconstructor.xcvrdnow resolvesdom_temperature_poll_intervalanddom_update_intervalitself from the"xcvrd"section ofpmon_daemon_control.json(viaXcvrdConfig), so the supervisord template no longer needs to readxcvrd.dom_temperature_poll_interval/xcvrd.dom_update_intervaland pass them as command-line flags. This removes the coupling between the template and individual xcvrd config keys, so adding future tunables won't require template changes.Work item tracking
How I did it
Removed the two
{% if xcvrd and xcvrd.dom_* %}template blocks fromdocker-pmon.supervisord.conf.j2that appended--dom_temperature_poll_interval/--dom_update_intervalto thexcvrdcommand line.How to verify it
Rendered
docker-pmon.supervisord.conf.j2directly with Jinja2 for both cases: (1) noxcvrdcontext var defined, and (2)xcvrddict withdom_temperature_poll_interval/dom_update_intervalset. In both cases the generated[program:xcvrd]command=line has no--dom_*flags, confirming removal is safe regardless ofpmon_daemon_control.jsoncontent. On thexcvrdside,dom_temperature_poll_interval/dom_update_intervalare now read frompmon_daemon_control.jsondirectly viaXcvrdConfig, exercised by thesonic-xcvrdunit test suite (tests/test_xcvrd_config.py,tests/test_xcvrd.py) insonic-platform-daemons(sonic-net/sonic-platform-daemons#854, companion change — should be merged together with, or after, this PR sincexcvrdno longer accepts these CLI flags once #854 lands).Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Removed obsolete
--dom_temperature_poll_interval/--dom_update_intervalCLI flags from thexcvrdsupervisord invocation indocker-pmon.supervisord.conf.j2.Link to config_db schema for YANG module changes
N/A — no YANG/config_db schema changes.
A picture of a cute animal (not mandatory but encouraged)